only add framestack body if framestack > 1 (#245)

* only add framestack body if framestack > 1 * print out python location for debugging * add import roms to github workflow * fix workflow * debug * pls work * more contrived script to get ALE roms
cpnota · May 28, 2021 · 4bef9a1 · 4bef9a1
1 parent 480071a
commit 4bef9a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -30,6 +30,7 @@ jobs:
         pip install torch==1.8.0+cpu -f https://download.pytorch.org/whl/torch_stable.html
         make install
         AutoROM -v
+        python -m atari_py.import_roms $(python -c 'import site; print(site.getsitepackages()[0])')/multi_agent_ale_py/ROM
     - name: Lint code
       run: |
         make lint

diff --git a/all/bodies/atari.py b/all/bodies/atari.py
@@ -6,7 +6,8 @@
 
 class DeepmindAtariBody(Body):
     def __init__(self, agent, lazy_frames=False, episodic_lives=True, frame_stack=4, clip_rewards=True):
-        agent = FrameStack(agent, lazy=lazy_frames, size=frame_stack)
+        if frame_stack > 1:
+            agent = FrameStack(agent, lazy=lazy_frames, size=frame_stack)
         if clip_rewards:
             agent = ClipRewards(agent)
         if episodic_lives: