-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add workflow to cleanup after project was created from template #3
Conversation
Add a workflow that cleansup the created project. Basically it does the following: - Rename cmake project to the github repository name - Replace some placeholder with the information from the new project in a README template. Then move it into place. - delete everything from the cleanup process
I'll close the PR while i am working on it so not every push wants to trigger the workflows |
I guess i have everything covered. I am not sure how to test if the search and replace worked out correctly,,, currently i just print the diff. |
Codecov Report
@@ Coverage Diff @@
## main cpp-best-practices/cpp_starter_project#3 +/- ##
=======================================
Coverage ? 72.72%
=======================================
Files ? 3
Lines ? 33
Branches ? 19
=======================================
Hits ? 24
Misses ? 8
Partials ? 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This is amazing. I just left one small suggestion for catching some of the C++ things and I'm also wondering if you think we can do anything with this? https://github.com/cpp-best-practices/cpp_boilerplate_project/blob/main/CMakeLists.txt#L38-L39 I think HOMEPAGE_URL should be relatively easy to take care of. Description, I'm concerned about newlines or something else breaking CMake. |
I agree. @lefticus i wonder if it would be a good idea to run cmake configure before commiting the changes inside the workflow? That makes it more complex but would catch any problems the replace introduces to the cmake files |
I think that would make sense. Just need to make sure cmake and conan are installed. And on that note - has anyone else noticed that docopt conan just stopped working on Windows CI? All of my builds with it are broken. I'm going to have to look into that. Maybe move away from docopt entirely here. |
@LtdSauce I think it would be safe to auto-fill the description inside of CMake, because it doesn't seem to be possible to create a multi-line description when using the template project |
Co-authored-by: Jason Turner <jason@emptycrate.com>
This PR was moved from the cpp_starter_project (cpp-best-practices/gui_starter_template#197).
This PR implements a first simple workflow to do some cleanup inspired by #5.
As community/community#5336 is not implemented by github, this PR should workaround that need for a template project.
Goals of this PR: