Try to use UNITY_BUILD #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With CMAKE_UNITY_BUILD there are build error with ftxui! Quickfix: don't build ftxui_sample if CMAKE_UNITY_BUILD is set.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #63 +/- ##
==========================================
Coverage ? 24.70%
==========================================
Files ? 6
Lines ? 251
Branches ? 142
==========================================
Hits ? 62
Misses ? 181
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClausKlein
commented
Aug 27, 2023
Comment on lines
+56
to
+58
| option(myproject_ENABLE_UNITY_BUILD "Enable unity builds" ON) | ||
| option(myproject_ENABLE_CLANG_TIDY "Enable clang-tidy" OFF) | ||
| option(myproject_ENABLE_CPPCHECK "Enable cpp-check analysis" OFF) |
There was a problem hiding this comment.
IMHO: developers shouldn't wast its time.
run-clang-tidy -p out/builddir is easy to use
Only on CI clang-tidy must at least run one times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With CMAKE_UNITY_BUILD there are build error with
ftxui!ftxui_sampleifCMAKE_UNITY_BUILDis set.