Enforce the use of override
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning is available on GCC since 5.1 and Clang since 11.0.0. Since GCC 9.2 it also does not warn if 'final' is used instead of 'override'. This was the case in Clang since the warning was introduced.
I did not realise Clang 6 was the earliest supported Clang version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 24.70% 24.70%
=======================================
Files 6 6
Lines 251 251
Branches 142 143 +1
=======================================
Hits 62 62
Misses 181 181
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lefticus
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wsuggest-overridehas been available on GCC since 5.1. It warns if a member function overrides a base class function, but is not markedoverride(orfinalsince GCC 9.2).It appears that Visual Studio has a similar warning, but not being a Visual Studio user, I can't figure out how to enable it.
Since the template says it should work with Clang 6, and this warning was introduced in Clang in version 11.0.0, I only enabled it for GCC.