allow version to be a path

[2bndy5]

resolves #94

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (b93b1da) to head (9eea4eb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   95.92%   96.12%   +0.20%     
==========================================
  Files           7        7              
  Lines         270      284      +14     
==========================================
+ Hits          259      273      +14     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[2bndy5]

The MacOS runners are having the same trouble stated in cpp-linter/cpp-linter-action#237

[shenxianpeng]

I just finished my trip, sorry for the late reply.

[2bndy5]

Oh, not a problem. I didn't know you were on vacation. There's no real rush anyway. Not many users are using a path as the specified version.

[shenxianpeng]

usage: clang-tools [-h] [-i VERSION] [-t TOOL [TOOL ...]] [-d DIR] [-f] [-b] [-u VERSION]

options:
  -h, --help            show this help message and exit
  -i VERSION, --install VERSION
                        Install clang-tools about a specific version.
  -t TOOL [TOOL ...], --tool TOOL [TOOL ...]
                        Specify which tool(s) to install.
  -d DIR, --directory DIR
                        The directory where the clang-tools are installed.
  -f, --overwrite       Force overwriting the symlink to the installed binary. This will only overwrite an existing symlink.
  -b, --no-progress-bar
                        Do not display a progress bar for downloads.
  -u VERSION, --uninstall VERSION
                        Uninstall clang-tools with specific version. This is done before any install.

Maybe we should update the following part of clang-tools help as well.

-i VERSION, --install VERSION
                        Install clang-tools about a specific version.

[2bndy5]

Sure. Although, this is behavior/PR is specific to cpp-linter-action.

[2bndy5]

I amended the help string as suggested.

I also took the time to update the generated doc about the CLI options. It now looks more like cpp-linter CLI doc with badges for minimum version and default value (if not an empty string). I added a badge (where applicable) to indicate the option is a switch/flag (which accepts no value).

[2bndy5]

I just noticed a regression about v12 vs v12.0.1

These changes currently ignore the minor and patch versions if specified. I have to think on this for a better solution.

[2bndy5]

I fixed the regression by storing the parsed version tuple as a class (Version) instance attribute. Then passing the Version instance to functions that need both string and 3-tuple of integers.

[2bndy5]

This is essentially blocked by an issue with the built static binaries. Any objection to merging/releasing this to get it upstream?

[shenxianpeng]

I have no objection to merge and release. I just have a question about help.

With the help of a path that points to the directory where the binaries already exist. it seems clang-tools support installation like below, but it does not support as expected. (ref the output below)

gitpod /workspace/clang-tools-pip (handle-version-path) $ ls /usr/lib/llvm-15/bin/clang-tidy
/usr/lib/llvm-15/bin/clang-tidy
gitpod /workspace/clang-tools-pip (handle-version-path) $ ls /usr/lib/llvm-15/bin/clang-format 
/usr/lib/llvm-15/bin/clang-format
gitpod /workspace/clang-tools-pip (handle-version-path) $ clang-tools -i  /usr/lib/llvm-15
The version specified is not a semantic specification
gitpod /workspace/clang-tools-pip (handle-version-path) $ clang-tools -i  /usr/lib/llvm-15/bin
The version specified is not a semantic specification
gitpod /workspace/clang-tools-pip (handle-version-path) $ clang-tools -i  /usr/lib/llvm-15/bin/clang-format 
The version specified is not a semantic specification

[sonarcloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud