addresses #7 #9
Merged
addresses #7 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hillmich You could test the patch in your CI by using |
hillmich
reviewed
Sep 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 80.75% 80.59% -0.17%
==========================================
Files 6 6
Lines 639 644 +5
==========================================
+ Hits 516 519 +3
- Misses 123 125 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The changes look good to me and they work locally and in the CI of my project 👍 |
shenxianpeng
approved these changes
Sep 8, 2022
shenxianpeng
reviewed
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.