Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Misc #188

Merged
merged 9 commits into from
Mar 1, 2022
Merged

[ENH] Misc #188

merged 9 commits into from
Mar 1, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Mar 1, 2022

@Remi-Gau Remi-Gau changed the base branch from master to dev March 1, 2022 10:47
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #188 (dd639a6) into dev (045a25a) will decrease coverage by 2.35%.
The diff coverage is 32.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #188      +/-   ##
==========================================
- Coverage   80.30%   77.95%   -2.36%     
==========================================
  Files          31       29       -2     
  Lines         650      635      -15     
==========================================
- Hits          522      495      -27     
- Misses        128      140      +12     
Flag Coverage Δ
unittests 77.95% <32.00%> (-2.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/convertSourceToRaw.m 0.00% <0.00%> (ø)
src/saveEventsFile.m 91.78% <ø> (ø)
src/utils/isPositiveInteger.m 100.00% <100.00%> (ø)
src/utils/printCreditsCppBids.m 21.87% <0.00%> (-75.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045a25a...dd639a6. Read the comment docs.

@Remi-Gau Remi-Gau merged commit 45061ba into cpp-lln-lab:dev Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] [TEST] failing tests in CI make isPositiveInteger accept row OR column vector
1 participant