Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] filter file volume #492

Merged
merged 6 commits into from
Jan 25, 2022
Merged

[ENH] filter file volume #492

merged 6 commits into from
Jan 25, 2022

Conversation

Remi-Gau
Copy link
Contributor

  • create bidsFitler options to specify what counts as 'bold', 'T1w'...
    • should in the long term replace opt.query as it allows to specify different "query" options for anatomical and functional data in a single place
  • add opt.funcVolToSelect to specify which volumes to include in spatial preprocessing (though this will create a 4D volume with "empty time points") or for GLM

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #492 (d0fbbf8) into dev (e019a58) will decrease coverage by 0.03%.
The diff coverage is 75.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #492      +/-   ##
==========================================
- Coverage   73.36%   73.33%   -0.04%     
==========================================
  Files         189      190       +1     
  Lines        3924     3945      +21     
==========================================
+ Hits         2879     2893      +14     
- Misses       1045     1052       +7     
Flag Coverage Δ
unittests 73.33% <75.67%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/QA/functionalQA.m 0.00% <0.00%> (ø)
src/bids/getInfo.m 100.00% <ø> (ø)
src/reports/copyFigures.m 87.50% <ø> (ø)
src/subject_level/fileFilterForGlm.m 100.00% <ø> (ø)
src/workflows/preproc/bidsSpatialPrepro.m 78.26% <ø> (ø)
src/utils/returnVolumeList.m 92.85% <92.85%> (ø)
src/batches/preproc/setBatchRealign.m 84.21% <100.00%> (+0.28%) ⬆️
src/batches/stats/setBatchSubjectLevelGLMSpec.m 92.04% <100.00%> (+0.83%) ⬆️
src/bids/addStcToQuery.m 100.00% <100.00%> (ø)
src/bids/getBoldFilename.m 77.77% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e019a58...d0fbbf8. Read the comment docs.

@Remi-Gau Remi-Gau merged commit cfd0807 into dev Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant