fix #545 add more options for segmentation batch #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was looking this up for something else this morning: The events that trigger a build of the doc are in: settings --> webhook https://github.com/cpp-lln-lab/CPP_SPM/settings/hooks/291828131 |
Remi-Gau
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Looks good to me.
I should try to fix the failing tests in another PR because it becomes hard to know if a PR breaks something: I can tell you that the changes you did are not related to those tests failing but if I get hit by a bus tomorrow this knowledge will be lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs will be updated automatically, correct?