Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] creates BIDS valid filename for ROIs in individual space #562

Merged
merged 5 commits into from
May 11, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented May 11, 2022

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #562 (5cea4e1) into dev (c5884c3) will increase coverage by 1.30%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##              dev     #562      +/-   ##
==========================================
+ Coverage   73.47%   74.78%   +1.30%     
==========================================
  Files         183      184       +1     
  Lines        4483     4469      -14     
==========================================
+ Hits         3294     3342      +48     
+ Misses       1189     1127      -62     
Flag Coverage Δ
unittests 74.78% <56.66%> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/workflows/roi/bidsCreateROI.m 0.00% <0.00%> (ø)
src/bids/buildIndividualSpaceRoiFilename.m 100.00% <100.00%> (ø)
src/workflows/bidsChangeSuffix.m 91.17% <100.00%> (+91.17%) ⬆️
src/infra/setGraphicWindow.m 81.81% <0.00%> (+27.27%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau merged commit ceeb870 into cpp-lln-lab:dev May 11, 2022
@Remi-Gau Remi-Gau deleted the CPP_ROI branch May 11, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant