Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] adapt group level analysis to work with BIDS stats model #581

Merged
merged 20 commits into from
May 22, 2022
Merged

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented May 22, 2022

  • dataset level GLM directories will be based on the Node.Name (if different from the default "dataset_level") and not on the BIDS stats model name (closes [ENH]: RFX folder naming #518)
  • can choose which dataset level Node to run analysis on as an argument in bidsRFX
  • better BIDS but not yet complete implementation of BIDS stats model at the dataset level
    • only stats model that get contrast from a subject level are implemented for now and perform a group average (one sample t-tests) are supported for now
      • assumes that dataset level nodes have GroupBy == 'contrast' and Model.X = 1

@Remi-Gau Remi-Gau changed the base branch from main to dev May 22, 2022 10:09
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #581 (ad08760) into dev (e775165) will increase coverage by 1.85%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##              dev     #581      +/-   ##
==========================================
+ Coverage   71.91%   73.76%   +1.85%     
==========================================
  Files         191      197       +6     
  Lines        4657     4738      +81     
==========================================
+ Hits         3349     3495     +146     
+ Misses       1308     1243      -65     
Flag Coverage Δ
unittests 73.76% <87.50%> (+1.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batches/stats/setBatchGroupLevelResults.m 0.00% <0.00%> (ø)
src/batches/stats/setBatchSubjectLevelGLMSpec.m 91.95% <ø> (-0.44%) ⬇️
src/subject_level/specifyContrasts.m 80.00% <ø> (+0.60%) ⬆️
src/workflows/stats/bidsResults.m 49.48% <0.00%> (-0.52%) ⬇️
src/bids_model/checkContrast.m 38.46% <38.46%> (ø)
src/bids_model/getSourceNode.m 83.33% <83.33%> (ø)
src/batches/stats/setBatchFactorialDesign.m 90.90% <87.93%> (+71.30%) ⬆️
src/workflows/stats/bidsRFX.m 93.47% <88.46%> (+34.01%) ⬆️
src/bids_model/getContrastsList.m 96.00% <96.00%> (ø)
src/bids_model/getDummyContrastsList.m 96.00% <96.00%> (ø)
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau added this to the v2.0.0 milestone May 22, 2022
@Remi-Gau Remi-Gau linked an issue May 22, 2022 that may be closed by this pull request
1 task
@Remi-Gau Remi-Gau merged commit 4758abf into dev May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: RFX folder naming
1 participant