Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add F test #584

Merged
merged 35 commits into from
May 25, 2022
Merged

[ENH] add F test #584

merged 35 commits into from
May 25, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented May 24, 2022

relates to #244

  • implement F test at the run level
  • implement F test at the subject level

Unrelated

  • fix PDF building of the doc (though html link to svg images in the symlinked general_info.md) will be an issue to deal with
  • fix bidsConcatBetaTmaps to force it to run on the root node of the model and remove possibility to delete the beta maps

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #584 (7edae94) into dev (89eef2c) will increase coverage by 0.36%.
The diff coverage is 89.06%.

@@            Coverage Diff             @@
##              dev     #584      +/-   ##
==========================================
+ Coverage   73.76%   74.12%   +0.36%     
==========================================
  Files         197      199       +2     
  Lines        4738     4777      +39     
==========================================
+ Hits         3495     3541      +46     
+ Misses       1243     1236       -7     
Flag Coverage Δ
unittests 74.12% <89.06%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batches/stats/setBatchContrasts.m 100.00% <ø> (ø)
src/batches/stats/setBatchGroupLevelContrasts.m 100.00% <ø> (ø)
src/batches/stats/setBatchSubjectLevelResults.m 52.63% <0.00%> (ø)
src/utils/deregexify.m 0.00% <0.00%> (ø)
src/utils/rmTrialTypeStr.m 42.85% <42.85%> (-23.81%) ⬇️
src/subject_level/specifyContrasts.m 89.23% <94.44%> (+9.23%) ⬆️
src/batches/stats/setBatchSubjectLevelContrasts.m 94.73% <100.00%> (+1.87%) ⬆️
src/bids_model/checkContrast.m 38.46% <100.00%> (ø)
src/bids_model/getContrastsList.m 95.65% <100.00%> (-0.35%) ⬇️
src/utils/getRegressorIdx.m 100.00% <100.00%> (ø)
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau changed the title [ENH] add parametric modelling and F test [ENH] add F test May 25, 2022
@Remi-Gau Remi-Gau merged commit d14cdca into cpp-lln-lab:dev May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant