Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] prevent some crashes if Model.Input are not passed as arrays #650

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

Remi-Gau
Copy link
Contributor

fixes #642

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #650 (dd3f97c) into main (5af726b) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   75.92%   75.92%   -0.01%     
==========================================
  Files         210      210              
  Lines        5317     5321       +4     
==========================================
+ Hits         4037     4040       +3     
- Misses       1280     1281       +1     
Flag Coverage Δ
unittests 75.92% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/workflows/stats/bidsFFX.m 75.71% <50.00%> (-0.76%) ⬇️
src/defaults/getOptionsFromModel.m 97.91% <100.00%> (+0.09%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau merged commit 4a44ecb into cpp-lln-lab:main Jun 15, 2022
@Remi-Gau Remi-Gau deleted the space branch June 15, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] bidsFFX fails if using one space only but opt.space was not coerced into cell
1 participant