Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] add more explicit error message for input parsing of getData #726

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

Remi-Gau
Copy link
Contributor

fixes #724

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #726 (7e3f24f) into main (5795c33) will decrease coverage by 0.05%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   76.21%   76.16%   -0.06%     
==========================================
  Files         214      214              
  Lines        5513     5514       +1     
==========================================
- Hits         4202     4200       -2     
- Misses       1311     1314       +3     
Flag Coverage Δ
unittests 76.16% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/IO/getData.m 93.93% <87.50%> (-2.36%) ⬇️
src/subject_level/convertOnsetTsvToMat.m 90.54% <0.00%> (-3.14%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Remi-Gau Remi-Gau merged commit eeb9a71 into cpp-lln-lab:main Jul 20, 2022
@Remi-Gau Remi-Gau deleted the fixes branch August 24, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] give more explicit error message when getData tries to get the layout of an invalid directory
1 participant