Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] avoid duplicate contrasts #816

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

Remi-Gau
Copy link
Contributor

fix #815

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #816 (2112b39) into main (b029baa) will increase coverage by 0.06%.
The diff coverage is 81.89%.

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   78.06%   78.12%   +0.06%     
==========================================
  Files         221      227       +6     
  Lines        5816     5837      +21     
==========================================
+ Hits         4540     4560      +20     
- Misses       1276     1277       +1     
Flag Coverage Δ
matlab 77.96% <81.89%> (-0.10%) ⬇️
octave 75.99% <81.89%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/subject_level/getEventSpecificationRoiGlm.m 92.42% <ø> (ø)
src/subject_level/specifyContrasts.m 77.77% <41.17%> (-11.46%) ⬇️
src/subject_level/specifySubLvlContrasts.m 85.18% <85.18%> (ø)
src/subject_level/specifyDummyContrasts.m 88.00% <88.00%> (ø)
src/bids_model/getContrastsListFromSource.m 88.88% <88.88%> (ø)
src/bids_model/checkGroupBy.m 100.00% <100.00%> (ø)
src/bids_model/getContrastsList.m 100.00% <100.00%> (+4.76%) ⬆️
src/subject_level/appendContrast.m 100.00% <100.00%> (ø)
src/subject_level/getSessionForRegressorNb.m 100.00% <100.00%> (ø)
src/subject_level/newContrast.m 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit bf12265 into cpp-lln-lab:main Nov 15, 2022
@Remi-Gau Remi-Gau deleted the duplicate_contrasts branch December 7, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] duplicate subject level contrast created
1 participant