Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] add argument groups to python cli #907

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jan 6, 2023

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 6, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.66%.

Quality metrics Before After Change
Complexity 0.14 ⭐ 0.13 ⭐ -0.01 👍
Method Length 116.40 🙂 120.60 😞 4.20 👎
Working memory 2.56 ⭐ 3.22 ⭐ 0.66 👎
Quality 75.94% 75.28% -0.66% 👎
Other metrics Before After Change
Lines 301 307 6
Changed files Quality Before Quality After Quality Change
src/parsers.py 75.94% ⭐ 75.28% ⭐ -0.66% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/parsers.py common_parser 0 ⭐ 465 ⛔ 3 ⭐ 67.36% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #907 (3c3d858) into main (b58b536) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   78.54%   78.57%   +0.02%     
==========================================
  Files         243      243              
  Lines        6437     6440       +3     
  Branches       40       40              
==========================================
+ Hits         5056     5060       +4     
+ Misses       1365     1364       -1     
  Partials       16       16              
Flag Coverage Δ
cli 39.01% <100.00%> (+0.70%) ⬆️
matlab 80.18% <ø> (+0.01%) ⬆️
octave 78.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/parsers.py 88.88% <100.00%> (+0.65%) ⬆️
src/infra/getEnvInfo.m 66.21% <0.00%> (+1.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit 569742d into cpp-lln-lab:main Jan 6, 2023
@Remi-Gau Remi-Gau deleted the cli branch January 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant