Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA, DOC, REF] Misc #105

Merged
merged 34 commits into from
Mar 9, 2022
Merged

[INFRA, DOC, REF] Misc #105

merged 34 commits into from
Mar 9, 2022

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Mar 2, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #105 (22daf9b) into dev (3cbd375) will increase coverage by 2.47%.
The diff coverage is 44.94%.

❗ Current head 22daf9b differs from pull request most recent head 7fcb87f. Consider uploading reports for the commit 7fcb87f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #105      +/-   ##
==========================================
+ Coverage   41.07%   43.54%   +2.47%     
==========================================
  Files          15       17       +2     
  Lines         224      395     +171     
==========================================
+ Hits           92      172      +80     
- Misses        132      223      +91     
Flag Coverage Δ
unittests 43.54% <44.94%> (+2.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
subfun/design/expDesign.m 73.33% <ø> (ø)
subfun/doDotMo.m 0.00% <0.00%> (ø)
subfun/postInitializationSetup.m 0.00% <0.00%> (ø)
subfun/visualMotionLocalizer.m 0.00% <0.00%> (ø)
subfun/defaults/checkParameters.m 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbd375...7fcb87f. Read the comment docs.

@marcobarilari
Copy link
Collaborator

Very nice, thanks!

So now everything that I would like to "customize" will go as cfg input into main.m before calling the func visualMotionLocalizer(cfg), correct?

Will add everything we need for our case and let's how long it will be.

Another thought I have is that it would be useful, at least for us, to have a main which is transversal to all the experiment we need to run (audio visual mst localizers and main experiment). This implies the the initEnv might have a path-to/initEnv() and that at the end of each run/task we should have a deactivateEnv() in case different experiments point to different version of eg CPP_PTB.

cfg.text.font = 'Courier New';
cfg.text.size = 18.000000;
cfg.text.style = 1.000000;
cfg.timing.IBI = 4.000000;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add cfg.timing.changeFixationPosition = 10;

@@ -0,0 +1,133 @@
# Configurations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this created automatically or manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually but I can work on some automation because I am already tired of copy pasting twice.

@Remi-Gau Remi-Gau merged commit 17901c0 into cpp-lln-lab:dev Mar 9, 2022
@Remi-Gau Remi-Gau deleted the misc branch March 9, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants