Skip to content

Commit

Permalink
Disable pip verbose in MSVC as it can cause false failures (#120)
Browse files Browse the repository at this point in the history
* MSVC detects the config test builds which are intended
  to fail as global build failures.
  • Loading branch information
hjmallon authored and rbsheth committed Jan 7, 2020
1 parent 2e17808 commit 58dbf64
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cmake/schemes/url_sha1_pip.cmake.in
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ configure_package_config_file(
INSTALL_DESTINATION "${config_install_dir}"
)

if(HUNTER_STATUS_DEBUG)
# We don't support verbose when building in MSVC as some pip packages (pip_numpy)
# run config test builds which are intended to fail, but cause MSVC to think the
# whole build has failed.
if(HUNTER_STATUS_DEBUG AND NOT MSVC)
set(pip_verbose "-vvv")
else()
set(pip_verbose "")
Expand Down

0 comments on commit 58dbf64

Please sign in to comment.