-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI Python versions where they have updated upstream #117
Conversation
* Travis make no guarantees for Python version stability on their images for macOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can lock python versions in our Travis builds like https://docs.travis-ci.com/user/languages/python/#specifying-python-versions. Would that fix this issue?
I have just updated this PR with MSYS fix (same thing seems to have happened) I am now getting all PASSED here |
That Python explicit method is only supported on Linux. MacOS / MSYS Python builds are not supported to the same extent.
Quote from the page you linked ^ |
In a previous project I have used this syntax
And this worked fine. I believe we should be able to do the same here |
I have just tried with python: 3.6 included in the Travis setup but it still uses 3.7.5. See logs here https://travis-ci.org/hjmallon/hunter/jobs/632318617 UPDATE: Found a relevant link, but no official info https://travis-ci.community/t/missing-python3-6-on-xcode9-4/6588/7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t have a problem with your change, just hoping we could find a way to lock that version so we don’t have to keep updating the code. If we don’t need a particular version, I wonder if we could query the active version rather than hardcoding
Yes, it would be nice to avoid the tests starting to fail due to CI updates. Perhaps whoever wrote that travis snippet with the more recent osx_image above might know if/when fixing versions works? |
It would be nice for us to find and/or lock the right version. For now, I suppose this'll do. |
stability on their images for macOS.
The version numbers in this file are meant to match those on the CI system. However, the macOS xcode9.4 image on Travis now has 3.7.5.
Here is a Travis run of the failing
pkg.pip_numpy
branch with this change on top showing macOS build success: