Update glfw package to 3.3.4 #479
Conversation
cmake/projects/glfw/hunter.cmake
Outdated
| VERSION | ||
| "3.3.4-p0" | ||
| URL | ||
| "https://github.com/cpp-pm/glfw/TODO" |
There was a problem hiding this comment.
https://github.com/cpp-pm/glfw/archive/refs/tags/v3.3.4-p0.tar.gz
with SHA1 68860fe3983bef0c73c21d23cc69c8aac9cf493c
There was a problem hiding this comment.
I accidentally pushed an older branch, my bad
alex-tdrn
force-pushed
the
pr.update_glfw_3_3_4
branch
2 times, most recently
from
20d4a96
to
469926e
Compare
|
LGTM, let's see what the CI has to say |
|
Sidenote: the 3 failing toolchains also fail on the 3.3.0 version of glfw, currently in hunter EDIT: The rebase is correct, but I'm still going to try to make the remaining toolchains work, with the original 20 patches as they seem to be necessary and smarter people than me have thought them out |
alex-tdrn
force-pushed
the
pr.update_glfw_3_3_4
branch
from
cff459a
to
be9c98c
Compare
|
I've removed the iOS and Android builds from the build matrix, since glfw does not support mobile platforms at the moment. The last failing build seems to originate from xcb, and indeed, the analyze build is failing for xcb as well (on current master). As a sidenote, a 3.3.5 tag was created upstream 2 hours ago, it looks like another release is coming, should we wait a bit and skip directly to that release instead? |
|
I think you should keep the failing jobs in the build matrix, as they are used for documentational purposes (there's a website listing the build status for the packages) As for waiting, just add this version and when the next one is released add the new version instead of potentially waiting and waiting |
|
ah yes here it is: Per package testing table |
| PACKAGE_NAME | ||
| glfw | ||
| VERSION | ||
| "3.3.4-p0" |
There was a problem hiding this comment.
Can you remove this version, if it isn't useful?
There was a problem hiding this comment.
I've deleted the p1 tag, and pointed the p0 tag to the latest glfw commit on the 3.3.4 branch now
|
@alex-tdrn could you rebase and squash the changes, otherwise LGTM |
Remove Android and iOS from build matrix GLFW does not support mobile platforms yet glfw/glfw#1726 Update glfw to version with updated huntergate Set default glfw version to 3.3.4-p1 Revert "Remove Android and iOS from build matrix" This reverts commit be9c98c. remove unnecessary version
alex-tdrn
force-pushed
the
pr.update_glfw_3_3_4
branch
from
d77bd30
to
9445116
Compare
I've followed this guide step by step carefully. [Yes]