Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: update to v3 as 1.1.1 is almost eol #668

Merged
merged 5 commits into from
Apr 13, 2023
Merged

openssl: update to v3 as 1.1.1 is almost eol #668

merged 5 commits into from
Apr 13, 2023

Conversation

res0nance
Copy link

@res0nance res0nance commented Apr 3, 2023 •
edited
Loading

No description provided.

@res0nance res0nance marked this pull request as ready for review April 5, 2023 09:54
NeroBurner
NeroBurner approved these changes Apr 13, 2023
View reviewed changes
Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks for your contribution and fast reaction to change-requests!

cmake/find/FindOpenSSL.cmake Show resolved Hide resolved
@NeroBurner NeroBurner added the package:update Add a new version to an existing package label Apr 13, 2023
@NeroBurner NeroBurner merged commit 15290a7 into cpp-pm:master Apr 13, 2023
16 of 20 checks passed
@res0nance res0nance deleted the openssl3-update branch April 13, 2023 15:42
@NeroBurner
Copy link

released: https://github.com/cpp-pm/hunter/releases/tag/v0.24.16

@rbsheth rbsheth mentioned this pull request Apr 13, 2023
Closed
neandreithal pushed a commit to regulaforensics/hunter that referenced this pull request Sep 22, 2023
@res0nance @neandreithal
openssl: update to v3.0.8 as v1.1.1 is almost eol (cpp-pm#668)
e23d0f1 
Add `--libdir=lib` parameter to configure step for hunter-compatibilty.
Upstream may now use `lib64` where it deems it appropriate, but we're still
generally using `lib` directory.

Update the bundled `FindOpenSSL.cmake` file to changes in how in v3 the version is specified.

---------

Co-authored-by: res0nance <res0nance@users.noreply.github.com>
@hjmallon
Copy link

Just trying the new OpenSSL, my version number is coming out as (found version "# define OPENSSL_VERSION_MAJOR 3.# define OPENSSL_VERSION_MINOR 1.# define OPENSSL_VERSION_PATCH 0")?

Looking at the CMake code I'm not sure file(STRINGS supports regex capture groups?

@NeroBurner
Copy link

Please open an issue and reference this PR

@hjmallon hjmallon mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeroBurner NeroBurner NeroBurner approved these changes

Assignees
No one assigned
Labels
package:update Add a new version to an existing package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@res0nance @NeroBurner @hjmallon