Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOURCE_SUBDIR for cmake scheme #95

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Add SOURCE_SUBDIR for cmake scheme #95

merged 1 commit into from
Dec 10, 2019

Conversation

NeroBurner
Copy link

fixes #94

@NeroBurner NeroBurner mentioned this pull request Dec 9, 2019
Closed
rbsheth
rbsheth requested changes Dec 9, 2019
View reviewed changes
Copy link
Member

@rbsheth rbsheth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should help add pesky packages without a CMakeLists.txt in the root! Couple comments.

cmake/configs/default.cmake Outdated Show resolved Hide resolved
cmake/modules/hunter_download.cmake Outdated Show resolved Hide resolved
cmake/modules/hunter_get_source_subdir.cmake Outdated Show resolved Hide resolved
cmake/projects/CMakeInSubdir/hunter.cmake Outdated Show resolved Hide resolved
cmake/projects/CMakeInSubdir/hunter.cmake Outdated Show resolved Hide resolved
examples/CMakeInSubdir/CMakeLists.txt Outdated Show resolved Hide resolved
examples/CMakeInSubdir/foo.cpp Outdated Show resolved Hide resolved
@NeroBurner @riegl-gc
add hunter_source_subdir and hunter_get_source_subdir
2753743 
Add possibility to set the sub-directory the project CMakeLists.txt is
in. This sets the parameter SOURCE_SUBDIR for ExternalProject_ADD.

Also add documentation in reference/user/modules.
The documentation points to zstd project, which will hopefully use this
feature.
@NeroBurner
Copy link
Author

I'd like to have a test for this feature, but I don't know how to add it to the tests. I know how to add a project to Hunter, so I used that for testing

bkotzz
bkotzz approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@bkotzz bkotzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should be fine to test with zstd.

@bkotzz bkotzz merged commit 357667a into cpp-pm:master Dec 10, 2019
@rbsheth
Copy link
Member

rbsheth commented Dec 11, 2019

Released: https://github.com/cpp-pm/hunter/releases/tag/v0.23.236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbsheth rbsheth rbsheth requested changes

@bkotzz bkotzz bkotzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support SOURCE_SUBDIR in cmake scheme
3 participants
@NeroBurner @rbsheth @bkotzz