Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header only consumption mode #136

Closed
mborland opened this issue Jan 24, 2024 · 1 comment
Closed

Add header only consumption mode #136

mborland opened this issue Jan 24, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mborland
Copy link
Member

See: https://github.com/boostorg/json#header-only

@mborland mborland added the enhancement New feature or request label Jan 24, 2024
@pdimov
Copy link
Member

pdimov commented Jan 24, 2024

This isn't a particularly good or useful idea. It's not practical to have a header-only option for this library. Either it should be always header-only, or always compiled.

That's because now every downstream consumer needs to pick a mode, and they all must pick the same mode. E.g. if JSON uses the library in header-only mode, and my code uses JSON, my code (and all its dependencies) also must use header-only mode. And conversely, if JSON uses compiled Charconv, everyone else must, too.

Also, the above link doesn't actually describe header-only, even though it's called such.

@mborland mborland closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants