Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BOOST_CHARCONV_STD_ERANGE with from_chars_strict #120

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Conversation

mborland
Copy link
Member

Closes: #110

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://120.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://120.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (06d8347) 88.02% compared to head (d8a0d2b) 88.25%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
+ Coverage    88.02%   88.25%   +0.22%     
===========================================
  Files           55       55              
  Lines         7861     7893      +32     
===========================================
+ Hits          6920     6966      +46     
+ Misses         941      927      -14     
Files Coverage Δ
include/boost/charconv/from_chars.hpp 100.00% <ø> (ø)
test/from_chars_float.cpp 98.58% <ø> (ø)
test/github_issue_110.cpp 100.00% <100.00%> (ø)
test/test_boost_json_values.cpp 99.59% <ø> (ø)
src/from_chars.cpp 96.42% <90.90%> (-1.35%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d8347...d8a0d2b. Read the comment docs.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://120.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

@mborland mborland merged commit 0e9dbf2 into develop Jan 18, 2024
53 checks passed
@mborland mborland deleted the strict branch January 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_chars incompatible with std::from_chars
2 participants