stream prepare has nullary overload #81
Conversation
|
Well shouldn't we remove the 1-arg overload? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #81 +/- ##
===========================================
+ Coverage 89.23% 89.37% +0.13%
===========================================
Files 77 77
Lines 4339 4348 +9
===========================================
+ Hits 3872 3886 +14
+ Misses 467 462 -5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
GCOVR code coverage report https://81.http-proto.prtest.cppalliance.org/gcovr/index.html |
| last_chunk_len_ = | ||
| 1 + // "0" | ||
| crlf_len_ + | ||
| crlf_len_; // chunked-body termination requires an extra CRLF | ||
|
|
||
| static | ||
| constexpr | ||
| std::size_t | ||
| chunked_overhead_ = |
There was a problem hiding this comment.
We might be able to use this constant in serializer::prepare() and serializer::capacity() too.
Good question. I didn't see a reason to outright remove it. I suppose users can take the return from |
cmazakas
force-pushed
the
feature/nullary-prepare
branch
from
c3e0dfb
to
d502b88
Compare
|
GCOVR code coverage report https://81.http-proto.prtest.cppalliance.org/gcovr/index.html |
| // last-chunk | ||
| // this enables users to call: | ||
| // | ||
| // stream.commit(n); stream.close(); |
There was a problem hiding this comment.
Nice comment... yes, this is a good goal
cmazakas
force-pushed
the
feature/nullary-prepare
branch
from
abc6d64
to
417cfb1
Compare
|
GCOVR code coverage report https://81.http-proto.prtest.cppalliance.org/gcovr/index.html |
1 similar comment
|
GCOVR code coverage report https://81.http-proto.prtest.cppalliance.org/gcovr/index.html |
cmazakas
force-pushed
the
feature/nullary-prepare
branch
from
e4dc57d
to
b2b46e8
Compare
|
GCOVR code coverage report https://81.http-proto.prtest.cppalliance.org/gcovr/index.html |
No description provided.