This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Shiny new process class and cleanup of terminal* #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, Windows implementation coming soon.
… Windows because of missing function in MSYS2.
|
Forgot: ready for merge if your tests go through. |
pull from cppit
|
Tested again on OS X, MSYS, Ubuntu 14. And also Debian testing. |
|
|
||
| Terminal::Terminal() { | ||
| bold_tag=get_buffer()->create_tag(); | ||
| bold_tag->property_weight()=PANGO_WEIGHT_BOLD; |
There was a problem hiding this comment.
Why not use enum directly? In terminal->print() we could add PANGO_WEIGHT_BOLD | PANGO_STYLE_ITALIC for instance.
There was a problem hiding this comment.
Saw that this is texttag which doesn't have operator|() overloaded so I guess just ignore this.
zalox
added a commit
that referenced
this pull request
Dec 5, 2015
Shiny new process class and cleanup of terminal*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on MSYS2, OS X and Ubuntu 14.