Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize public header files #43

Closed
saschazelzer opened this issue Sep 24, 2015 · 3 comments
Closed

Re-organize public header files #43

saschazelzer opened this issue Sep 24, 2015 · 3 comments
Assignees
Milestone

Comments

@saschazelzer
Copy link
Member

In anticipation of new modules in the source code, the public header files should be re-organized.

  • Core headers will be located under include/us
  • Other module headers will be located under include/<module>

All header files will be stripped of the "us" prefix and the us namespace will not be optional / changeable any more.

Header files also must not depend on configured information.

@karthikreddy09
Copy link
Member

@jeffdiclemente
I like this idea ... headers in specific folders avoids conflict with similar named headers in global scope.

Would it make sense to use include/CppMicroServices instead of include/us ? I think it helps with readability in client code.

#include "CppMicroServices/Bundle.hpp"
vs
#include "us/Bundle.hpp"

@saschazelzer
Copy link
Member Author

You are right, it is definitely more expressive, but also a lot more to type. I would like to get opinions from more people about this.

@lygstate
Copy link

I like #include "us/Bundle.hpp"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants