Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Remove options to disable std C library #1658

Closed
wants to merge 1 commit into from

Conversation

thetic
Copy link
Contributor

@thetic thetic commented Oct 30, 2022

As best I can tell, this functionality has rotted. I don't think it is feasible or responsible to attempt to maintain functionality that is not under test. I think repair/test would require some significant redesign. As such I propose to remove it outright.

Closes #1656.

@coveralls
Copy link

coveralls commented Oct 30, 2022

Coverage Status

Coverage remained the same at 99.64% when pulling 503de82 on thetic:no-no-std-c into 8cc621c on cpputest:master.

@thetic thetic marked this pull request as ready for review October 31, 2022 00:07
@thetic thetic changed the title Remove options to disable std C library Proposal: Remove options to disable std C library Oct 31, 2022
@basvodde
Copy link
Member

I don't really want to remove the feature as it is used when using CppUTest in e.g. Linux kernel development. That is when we added it.

@thetic
Copy link
Contributor Author

thetic commented Oct 31, 2022

Is there a version known to work or are there special instructions for testing it? I'd like to get it in CI if we want to keep it.

@basvodde
Copy link
Member

The main thing is to keep the compiling in the CI. When that is in there then it isn't possible to include StdC headers directly without failing the build. So keeping that build then prevents regression. Then when people want to use CppUTest on kernel development or embedded development that has no stdC then they just need to implement the PlatformSpecific functions.

I have been thinking to try to implement some of the PlatformSpecific functions in an as much platform independent way (such as having a printf implementation) but haven't ever gotten to it and not sure it will actually be worth it.

@thetic
Copy link
Contributor Author

thetic commented Oct 31, 2022

I understand how to test that it builds, but how do we test that it works?

@thetic
Copy link
Contributor Author

thetic commented Oct 31, 2022

Let's continue discussion on #1656

@thetic thetic closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use without C stdlib is untested
3 participants