Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored RTTI feature detection and moved it to the config header. #1671

Merged
merged 1 commit into from Nov 8, 2022

Conversation

dmitrykos
Copy link
Contributor

In response to #1670 cleans up the fix by moving RTTI detection into the config header.

@coveralls
Copy link

coveralls commented Nov 7, 2022

Coverage Status

Coverage remained the same at 99.625% when pulling 74b2af8 on dmitrykos:cleanup-rtti-detection into 775e760 on cpputest:master.

@dmitrykos
Copy link
Contributor Author

Had to cleanup PR due to outdated source on my side, now looks fine.

@thetic
Copy link
Contributor

thetic commented Nov 7, 2022

RTTI support can be directly inspected with C++20 https://en.cppreference.com/w/User:D41D8CD98F/feature_testing_macros

@dmitrykos
Copy link
Contributor Author

@thetic thank you for the proposal, added __cpp_rtti. I did not add a check for its value but checked for presence only similar to GCC's libstdc++.

@basvodde
Copy link
Member

basvodde commented Nov 8, 2022

Thanks, that looks much better.

@basvodde basvodde merged commit e3fb168 into cpputest:master Nov 8, 2022
@dmitrykos dmitrykos deleted the cleanup-rtti-detection branch November 8, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants