Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon attempts to auto-tag and release #1736

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

thetic
Copy link
Contributor

@thetic thetic commented Dec 29, 2022

None of the available GitHub actions allow us to "move" an existing latest-passing-build tag. GitHub expects tags to go unmutated. It seems we've been trying to use a tag as a branch.

I think this is fine. We shouldn't be merging anything that doesn't build; master effectively serves the same purpose.

@coveralls
Copy link

coveralls commented Dec 29, 2022

Coverage Status

Coverage: 99.323%. Remained the same when pulling 808765d on thetic:deploy into fd25857 on cpputest:master.

None of the available GitHub actions allow us to "move" an existing
`latest-passing-build` tag. GitHub expects tags to go unmutated.

I think this is fine. We shouldn't be merging anything that doesn't
build; master effectively serves the same purpose.
@basvodde
Copy link
Member

basvodde commented Jan 5, 2023

It is ok for now. I had this working at some point in the far past... but had written a small tool to help me with that. I didn't have time/priority to keep that up to date. So, let's abandon it for now. Thanks for the effort

@basvodde basvodde merged commit 8618552 into cpputest:master Jan 5, 2023
@thetic thetic deleted the deploy branch January 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants