Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and apply clang-format settings #1778

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thetic
Copy link
Contributor

@thetic thetic commented Mar 30, 2024

Resurrecting effort from #1631.

I recommend hiding whitespace changes to "denoise" the diff.

image

#else
struct tm *tmp = localtime(&theTime);
struct tm* tmp = localtime(&theTime);

Check failure

Code scanning / CodeQL

Use of potentially dangerous function Critical

Call to 'localtime' is potentially dangerous.
@@ -615,10 +617,13 @@
MemoryLeakWarningPlugin::MemoryLeakWarningPlugin(const SimpleString& name, MemoryLeakDetector* localDetector) :
TestPlugin(name), ignoreAllWarnings_(false), destroyGlobalDetectorAndTurnOfMemoryLeakDetectionInDestructor_(false), expectedLeaks_(0)
{
if (firstPlugin_ == NULLPTR) firstPlugin_ = this;
if (firstPlugin_ == NULLPTR)
firstPlugin_ = this;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
may be assigned to a non-local variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant