-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitup the Test Macro file, alternative #953
Conversation
I have no objections to this solution, but could you please put the new files into sources.mk for Dos and see that the Dos build is indeed fixed. I am not sure about this, as the long long functions are prone to generate a lot of assembler code and I have no idea whether the string funcitons will outweigh them. |
Needless to say that TestTestingFixture is cleaner this way :-) |
It still needs to be cleaned up a bit though... |
I'm kind of fond of my "hack" in the header though. I wouldn't have thought I could make the static functiosn work without a source file :P |
I'd prefer moving everything to the source file anyway. It was already something that should have happened. |
Can't really dispute that :D. Are you going to make the changes needed to platforms/dos/sources.mk? Or how should we approach that? Should I submit a PR against basvodde/master? |
Yes, will gradually :) Let me see the failure reasons. |
For starters and obvious reasons, you need src/CppUTest/TestTestingFixture.cpp in the dos buid.... |
Same goes for Cmake builds. Interesting failures for Autotools, and also interesting that Cygwin succeded :-/ |
@@ -14,7 +14,7 @@ set(CppUTest_src | |||
MemoryLeakDetector.cpp | |||
TestFilter.cpp | |||
TestPlugin.cpp | |||
TestTestingPlugin.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/me an idiot not paying attention :)
The FAIL_LOCATION lines need to be commented with |
I'll merge this, the Vistual Studio files need fixing still though :( |
Alternative split by splitting out String functions