Arctic admin causes JS errors in browser logs

[michalzynek]

I have error in browser console since I installed arctic admin:

Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined

And not only me I guess:
https://stackoverflow.com/questions/52857201/uncaught-typeerror-cannot-read-property-getboundingclientrect-of-undefined-on

[wachub]

• Hi, it seems to occur in this js file at two points here and here.

• In both those cases, the issue seems to be that when the tabs array is empty, there is a null value related exception when the first element of the empty array is referenced as a DOM object and the getBoundingClientRect() function is called on that.

• From what I understand, it shouldn't break compatibility with the existing code for the width to be initially set to zero and for the getBoundingClientRect().width function to be called only when the tabs array is not empty.

[michalzynek]

hello @wachub , thank you for your response

My dirty workaround, for then, was (in application.html.haml - head section):

- if request.url.include? '/admin'
      = javascript_include_tag 'active_admin', 'data-turbolinks-track': 'reload'

As indeed, it broke some of my JS files, I do not remember what it was exactly (old times) but I think related to owl-carousel plugin or iziModal.

[wachub]

Hi @michalzynek. Could you check out this pull request #75 . Unfortunately I understand very little of rails and I haven't heard of .haml files at all till now. So I am in no position to verify your solution.

Anyway from the little that I do understand, i think your code simply says that the javascript tag should be included when the http request goes to admin. However I think all the activeAdmin js files are included for all http requests by default.

[michalzynek]

@wachub in my example, the files were not only included on ActiveAdmin module - maybe that was a mistake of my configurations somewhere, but above Haml is simple HTML that says the JS files from ActiveAdmin should only be included under /admin path.

UPDATE: I saw your PR, it may have fixed the error as I see you are checking the tabs existence. However, I am concerned about loading those files in locations different than ActiveAdmin engine

[wachub]

Hi @michalzynek . AFAIK, this bug is a fairly low level one (syntax level), which is independent of the logic/algorithm on top. The only assumption made is that the width can be taken to be zero when the array is empty, which seems consistent for whatever is written on top. I don't think it is likely to blow up anywhere else.