Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a modal and new trip form #63

Merged
merged 8 commits into from
Jun 3, 2023
Merged

create a modal and new trip form #63

merged 8 commits into from
Jun 3, 2023

Conversation

NLmeng
Copy link
Member

@NLmeng NLmeng commented Jun 3, 2023

closes #60 closes #58

Graywing13
Graywing13 reviewed Jun 3, 2023
View reviewed changes
Copy link
Contributor

@Graywing13 Graywing13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup looks clean 👏 well-documented too 🏕️ just some stylistic stuff to consider

client/src/components/common/Modal.js Show resolved Hide resolved
Graywing13
Graywing13 approved these changes Jun 3, 2023
View reviewed changes
Copy link
Contributor

@Graywing13 Graywing13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🏕️

client/src/components/MapElement/MapElement.js Outdated Show resolved Hide resolved
@NLmeng NLmeng merged commit 6a96534 into main Jun 3, 2023
1 check passed
@NLmeng NLmeng deleted the lymeng/modal+NewTrip branch June 3, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graywing13 Graywing13 Graywing13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Trip Form Generic Modal
2 participants
@NLmeng @Graywing13