Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Deprecation Warnings #28

Open
hashwin opened this issue Sep 1, 2019 · 3 comments
Open

React Deprecation Warnings #28

hashwin opened this issue Sep 1, 2019 · 3 comments

Comments

@hashwin
Copy link

hashwin commented Sep 1, 2019

Started getting a couple of deprecation warnings related to this library with a recent version of React:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ActionCableProvider
Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: ActionCableProvider
@JackHowa
Copy link

Updated this @hashwin. Waiting on approval for my pr #29 @cpunion

@fabiobarboza7
Copy link

still having this issue :/

@fabiobarboza7
Copy link

fabiobarboza7 commented Jan 22, 2020

I rewrote for new sintax but I dnd tested: Hope help on it :)

https://gist.github.com/fabiobarboza7/7954170aa0b539a5c8591759ec200107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants