Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lifecycle code mod renaming unsafe #29

Closed

Conversation

JackHowa
Copy link

@JackHowa JackHowa commented Sep 11, 2019

In response to #28 and for my own app, I wanted this to remove the warnings for react lifecycle deprecations. I ran npx react-codemod rename-unsafe-lifecycles based on react guidance. Nothing special but it'd be helpful for now https://reactjs.org/blog/2019/08/08/react-v16.9.0.html

@JackHowa
Copy link
Author

let me know if there's anything else I can do. should I use a fork of this instead? #26 (comment)

@JackHowa
Copy link
Author

@cpunion, what do you think? This prevents deprecations warnings on React 16.9. The lifecycle methods here won't work in React 17.0 without this codemod.

@adamjsimon
Copy link

@cpunion Any update on this pull request?

@JackHowa
Copy link
Author

JackHowa commented Oct 4, 2019

Looking forward to a response if you're free @cpunion. My team is a fan of this library. We want to prep for React 17 and remain using this library. Please let me know if there's anything I can do

@JackHowa
Copy link
Author

JackHowa commented Nov 8, 2019

Let me know @cpunion. Sorry, it's super small but seems like a few other people are requesting this as well

@JackHowa
Copy link
Author

JackHowa commented Dec 5, 2019

Is there anything I can do @cpunion? I can close this pr if this project is no longer maintained @mgoggin

@mgoggin
Copy link
Contributor

mgoggin commented Dec 5, 2019

@JackHowa Unfortunately, I'm no longer working on projects that use ActionCable with React so I likely won't be contributing much anymore.

@JackHowa
Copy link
Author

JackHowa commented Dec 12, 2019

I published a React 17 compatible version of this library. Hope this is helpful to other people as well

https://github.com/JackHowa/react-actioncable-provider

yarn add @thrash-industries/react-actioncable-provider

@JackHowa
Copy link
Author

@cpunion Is this package no longer maintained? Will close this pr if so

@JackHowa JackHowa closed this Feb 13, 2020
@JackHowa JackHowa deleted the feature/remove-deprecation-warnings branch April 14, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants