-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run lifecycle code mod renaming unsafe #29
Run lifecycle code mod renaming unsafe #29
Conversation
let me know if there's anything else I can do. should I use a fork of this instead? #26 (comment) |
@cpunion, what do you think? This prevents deprecations warnings on React 16.9. The lifecycle methods here won't work in React 17.0 without this codemod. |
@cpunion Any update on this pull request? |
Looking forward to a response if you're free @cpunion. My team is a fan of this library. We want to prep for React 17 and remain using this library. Please let me know if there's anything I can do |
Let me know @cpunion. Sorry, it's super small but seems like a few other people are requesting this as well |
@JackHowa Unfortunately, I'm no longer working on projects that use ActionCable with React so I likely won't be contributing much anymore. |
I published a React 17 compatible version of this library. Hope this is helpful to other people as well https://github.com/JackHowa/react-actioncable-provider yarn add @thrash-industries/react-actioncable-provider |
@cpunion Is this package no longer maintained? Will close this pr if so |
In response to #28 and for my own app, I wanted this to remove the warnings for react lifecycle deprecations. I ran
npx react-codemod rename-unsafe-lifecycles
based on react guidance. Nothing special but it'd be helpful for now https://reactjs.org/blog/2019/08/08/react-v16.9.0.html