Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use observer instead of scroll events #20

Closed
dascritch opened this issue Aug 3, 2017 · 4 comments
Closed

Use observer instead of scroll events #20

dascritch opened this issue Aug 3, 2017 · 4 comments

Comments

@dascritch
Copy link
Collaborator

cf https://hacks.mozilla.org/2017/08/intersection-observer-comes-to-firefox/

@dascritch
Copy link
Collaborator Author

dascritch commented Aug 23, 2017

dascritch added a commit that referenced this issue Sep 17, 2019
Use observer instead of scroll events #20
@dascritch
Copy link
Collaborator Author

dascritch commented Sep 17, 2019

Reverted 59a0cd6 , because observers on webcomponents seems not correctly checked in Firefox

Snippet for checking :

function check(elements) {
          console.log(elements[0].intersectionRatio, elements[0].isIntersecting, elements[0])
}
new IntersectionObserver(check).observe(document.getElementById('menu'));
new IntersectionObserver(check).observe(document.querySelector('cpu-audio'));

@dascritch
Copy link
Collaborator Author

Reported to Mozilla https://bugzilla.mozilla.org/show_bug.cgi?id=1581876

@dascritch
Copy link
Collaborator Author

Bug related to cpu-audio webcomponent : container not declared as block

dascritch added a commit that referenced this issue Sep 22, 2019
Use observer instead of scroll events #20
dascritch added a commit that referenced this issue Sep 22, 2019
Use observer instead of scroll events #20
dascritch added a commit that referenced this issue Sep 24, 2019
Use observer instead of scroll events #20
dascritch added a commit to dascritch/cpu-audio that referenced this issue Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant