Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configurable slot name #57

Merged
merged 4 commits into from
May 3, 2024
Merged

add configurable slot name #57

merged 4 commits into from
May 3, 2024

Conversation

DaemonSnake
Copy link
Contributor

add slot_name configuration option
if not set default to current behaviour (_walex postfix)

other changes include:

  • get_configs returns the keywords in the order of the given keys
  • add a query builder module and move dependent configs in the start of the Replication.Server

@cpursley cpursley merged commit f68e1df into cpursley:master May 3, 2024
1 check passed
@cpursley
Copy link
Owner

cpursley commented May 3, 2024

Merci beaucoup @DaemonSnake!

@DaemonSnake DaemonSnake deleted the slot_name branch May 3, 2024 17:33
@cpursley
Copy link
Owner

cpursley commented May 3, 2024

@DaemonSnake I'm getting this in my app with these new changes. Any ideas?:

2024-05-03 14:10:57.440 [notice] Application my_app exited: MyApp.Application.start(:normal, []) returned an error: shutdown: failed to start child: WalEx.Supervisor
    ** (EXIT) shutdown: failed to start child: WalEx.Replication.Supervisor
        ** (EXIT) shutdown: failed to start child: WalEx.Replication.Server
            ** (EXIT) :function_clause

@DaemonSnake
Copy link
Contributor Author

DaemonSnake commented May 5, 2024

oh sorry didn't see the notification, will look right now
got the error in that past when there was a handle_result that didn't have a matching clause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants