Durable slot #62
Merged
Durable slot #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the config option durable_slot(bool) - if enabled check if slot already exists / is still active - if any of those are true => raise - if multiple processes try to create a slot with the same name it will error, raise in that case - otherwise create durable slot and start it
enabled with option durable_slot: true cannot be started by more than 1 ReplicationConnection at the same time is actually durable (survives to server crash, marked as temporary: false) can be resumed
|
This is an awesome and very welcome improvement @DaemonSnake! Let me know if you have other PRs planned - I need to cut a new release soon. |
|
@DaemonSnake did you have any more changes you wanted to get in before I create a new release? |
|
@cpursley oh yes, will submit it today. Sorry for the late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for non-temporary replication slots
When the slot is restarted, it will start back at the last wal_end+1 that walex returned in the keep-alive reply to postgres.
Transactions processed between the last keep-alive and the interruption of walex will be replayed.
If event replay is problematic, the end-user must implement a way to mark LSN/transactions as processed to avoid re-processing.
Also event loss is possible currently in this situation:
we made another PR to address this and will submit it shortly