-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify time-to-end #828
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (19)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* partial ws update * extract more of the timer formatting
This PR simplifies the calculation of time-to-end timers
Previously we attempted finding if the event was going to start the day after, and show a countdown to its finish time.
This proved complex to coordinate with an event that was simply started late.
Assuming the clock would look wrong for most users since the second case (starting late) is by far more common, we decide to not handle day-after events.