End pause

[cpvalente]

Adding the ability to pause a timer when it ends
I am unsure if there is a use case for this.
The feature is suggested in #779

It also adds a few fixes and improvements

[coderabbitai]

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (18)

• apps/client/src/common/models/ViewSettings.type.ts is excluded by: none and included by: none
• apps/client/src/features/app-settings/panel-content/PanelContent.module.scss is excluded by: none and included by: none
• apps/client/src/features/app-settings/panel/general-panel/ViewSettingsForm.tsx is excluded by: none and included by: none
• apps/client/src/features/viewers/common/viewUtils.ts is excluded by: none and included by: none
• apps/client/src/features/viewers/minimal-timer/MinimalTimer.tsx is excluded by: none and included by: none
• apps/client/src/features/viewers/timer/Timer.tsx is excluded by: none and included by: none
• apps/server/src/api-data/view-settings/viewSettings.controller.ts is excluded by: none and included by: none
• apps/server/src/classes/data-provider/__tests__/DataProvider.test.ts is excluded by: none and included by: none
• apps/server/src/config/config.ts is excluded by: none and included by: none
• apps/server/src/models/dataModel.ts is excluded by: none and included by: none
• apps/server/src/services/TimerService.ts is excluded by: none and included by: none
• apps/server/src/services/__tests__/timerUtils.test.ts is excluded by: none and included by: none
• apps/server/src/services/rundown-service/RundownService.ts is excluded by: none and included by: none
• apps/server/src/services/runtime-service/RuntimeService.ts is excluded by: none and included by: none
• apps/server/src/services/timerUtils.ts is excluded by: none and included by: none
• apps/server/src/stores/runtimeState.ts is excluded by: none and included by: none
• packages/types/src/definitions/EndAction.type.ts is excluded by: none and included by: none
• packages/types/src/definitions/core/Views.type.ts is excluded by: none and included by: none

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[cpvalente]

@alex-Arc ,

I have removed the pause on end action and added a freeze end option to the view settings
This allows us to freeze the timer.

We should schedule a chat for some cleanup on what view settings are allowed, we can do that later. But the feature should work for now.

There are also some other improvements here