Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 2 review #897

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Beta 2 review #897

merged 2 commits into from
Apr 17, 2024

Conversation

cpvalente
Copy link
Owner

@cpvalente cpvalente commented Apr 16, 2024

Small PR from a demo of v3 beta

  • Tweaks on QuickAddButtons to make them less prominent and improve the hierarchy in the rundown
  • Potentially controversial, remove the public message.

This second point has been discussed before. It was my conclusion that, if there is a value in having a message from the editor to the signage screens, this message would not be shared in public and backstage screens

The decision for now is to remove the dataset and regroup on the screen design at a later stage

Summary by CodeRabbit

  • New Features

    • Updated button colors to a specific shade of gray in the Quick Add Block interface.
  • Bug Fixes

    • Adjusted placeholder text for 'Events per page' to reflect the new default value.
  • Refactor

    • Removed unused public message functionality across various components and services.
    • Cleaned up and reordered styles and grid layout for backstage and public viewer interfaces.
  • Style

    • Updated grid layouts and removed specific styles associated with now-unused features.
  • Tests

    • Updated end-to-end tests to remove checks for deprecated public message functionality.
  • Chores

    • Removed deprecated code and references related to public message display and handling across multiple files.

@cpvalente cpvalente requested a review from alex-Arc April 16, 2024 19:56
Copy link
Contributor

coderabbitai bot commented Apr 16, 2024

Walkthrough

The recent updates aim to standardize the pagination by setting a constant for the number of events per page across various components and removing functionalities related to public screen messages throughout the system. This includes changes in UI components, services, and tests to align with the removal of public message features and enhancements in UI consistency.

Changes

File Path Change Summary
.../schedule/ScheduleContext.tsx &
.../view-params-editor/constants.ts
Standardized the number of events per page to 10. Updated placeholders and initial values accordingly.
.../hooks/useSocket.ts &
.../message/MessageControl.tsx &
.../viewers/ViewWrapper.tsx &
.../viewers/backstage/Backstage.tsx &
.../viewers/public/Public.tsx
Removed all functionalities related to public screen messages, including UI components and state management.
.../quick-add-block/QuickAddBlock.tsx Updated button colors to a specific shade of gray for consistency.
.../viewers/backstage/Backstage.scss &
.../viewers/public/Public.scss
Adjusted grid layouts and styles, removed obsolete styles related to the public message container.
.../api-integration/integration.controller.ts &
.../services/message-service/MessageService.ts
Removed backend validations and properties related to public messages.
e2e/tests/features/201-message-control.spec.ts &
packages/types/src/definitions/runtime/MessageControl.type.ts
Updated test cases and data types to reflect the removal of public message functionalities.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cpvalente cpvalente merged commit 16a169b into master Apr 17, 2024
3 checks passed
@cpvalente cpvalente deleted the beta-2-review branch April 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants