Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid maven repo link #372

Merged
merged 1 commit into from
Feb 9, 2020
Merged

valid maven repo link #372

merged 1 commit into from
Feb 9, 2020

Conversation

keddok
Copy link
Contributor

@keddok keddok commented Feb 4, 2020

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems, or leave puzzles)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed
  • Title begins with the issue's number, then a short title
  • Description begins with the issue's number, then enumerates the changes - summarized - in bulletpoints
  • Description does not contain GitHub keywords (https://help.github.com/articles/closing-issues-using-keywords/).

This article will help you understand what we are looking for: https://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@0crat
Copy link
Collaborator

0crat commented Feb 4, 2020

@keddok/z this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @paulodamaso/z please review this and merge or reject

@yegor256 yegor256 merged commit 6eb85f8 into cqfn:master Feb 9, 2020
@yegor256
Copy link
Member

yegor256 commented Feb 9, 2020

@keddok thanks!

@0crat
Copy link
Collaborator

0crat commented Feb 9, 2020

Job gh:yegor256/jpeek#372 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Feb 9, 2020

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants