-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#472) - Remove checkstyle suppression #476
Conversation
@paulodamaso 0rat seems to have missed this PR, can you tell him to take it into scope? Thx :) |
@0crat in |
This pull request #476 is assigned to @vzurauskas/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
@paulodamaso The points listed in the PR description make sense, nothing to comment. Can be merged. |
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 10min) |
@0crat status |
@vzurauskas This is what I know about this job in C7JGJ00DP, as in §32:
|
@paulodamaso I think this should be assigned to QA now? |
@0crat out |
@sereshqua/z please review this job completed by @vzurauskas/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@0crat quality bad |
Quality is low, no payment, see §31 |
This is for #472.
The changes are small, but I verified that:
XmlGraph
just delegating to the second, and the second very similar toXmlGraph
as it is currently written.It also gave me the opportunity to understand what the code was doing, and I opened a few issues in cactoos and jpeek.