Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring bug about too many leading spaces #193

Closed
baudoliver7 opened this issue Feb 11, 2022 · 4 comments
Closed

Ignoring bug about too many leading spaces #193

baudoliver7 opened this issue Feb 11, 2022 · 4 comments

Comments

@baudoliver7
Copy link
Member

baudoliver7 commented Feb 11, 2022

For example, when I add this puzzle to my code :

* @todo #59:30min Generate code for JOOQ.
*  We need first set up JOOQ in the project to generate objects based
*  on tables of database. see theses links:
*   - https://www.jooq.org/doc/3.16/manual/getting-started/tutorials/jooq-in-7-steps/jooq-in-7-steps-step3/
*   - https://www.jooq.org/doc/3.16/manual/getting-started/tutorials/jooq-in-7-steps/jooq-in-7-steps-step4/

and run pdd like this on my project :

pdd -f /dev/null

Everything is ok so far.

But, 0pdd is unable to create the puzzle with this error message :

ERROR: src/main/java/com/supervisor/server/Main.java; puzzle at line #46; Too many leading spaces at 49:4; make sure all lines that include the puzzle body start at position #5.
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

See logs here

On another side, I think we should allow someone to create a puzzle designed like the one above :)

@yegor256
Copy link
Member

@baudoliver7 I believe it's a feature of a new version. @mbao01 right?

@baudoliver7
Copy link
Member Author

baudoliver7 commented Feb 11, 2022

@yegor256 @mbao01 Here is another puzzle (on artipie this time) that fails also :

* @todo #449:30min Support running DockerProxyIT test on Windows.
*  Running test on Windows uses `mcr.microsoft.com/dotnet/core/runtime` image.
*  Loading this image manifest fails with
*  "java.lang.IllegalStateException: multiple subscribers not supported" error.
*  It seems that body is being read by some other entity in Artipie,
*  so it requires investigation.

With the same message, preventing pdd to generate any puzzle on the project :

Reading src/test/java/com/artipie/docker/DockerProxyIT.java...
ERROR: src/test/java/com/artipie/docker/DockerProxyIT.java; puzzle at line #28; Too many leading spaces at 36:3; make sure all lines that include the puzzle body start at position #4.
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

See logs here for more details.

@mbao01
Copy link
Contributor

mbao01 commented Feb 11, 2022

@yegor256 this has been fixed in #187 but has not been released yet.

@baudoliver7 thank you for raising this issue. Issue #163 discusses the same points. Now, leading spaces are not needed in creating a puzzle. This will be out in the next release.

@baudoliver7
Copy link
Member Author

@mbao01 Great ! We look forward to this new version being released and used by 0pdd.
Thanks for this achievement !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants