Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#163] Use blank lines instead of indentation as issue body markers #187

Merged
merged 4 commits into from
Feb 11, 2022
Merged

[#163] Use blank lines instead of indentation as issue body markers #187

merged 4 commits into from
Feb 11, 2022

Conversation

mbao01
Copy link
Contributor

@mbao01 mbao01 commented Jan 3, 2022

Example:

Here's an example puzzle

# TODO: #1 Issue title
#
# ^ if you need an empty line for aesthetics
#
# Everything here is added as
# an issue body
#
# ... still the issue body

# This comment is left in the code (not part of puzzle body)
def greeting:
  print('Hello')

@yegor256
Copy link
Member

@mbao01 can you add a test to make sure this code produces TWO puzzles:

/**
 * @todo #1 First one with
 * a few lines
 * @todo #1 Second one also
 * with a few lines
 */

Or we already have such a test?

@mbao01
Copy link
Contributor Author

mbao01 commented Jan 10, 2022

@yegor256 We have a test that covers this scenario but I will add a test that explicitly tests only this.

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 10, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jan 10, 2022

@rultor merge

@mbao01 @yegor256 Oops, I failed. You can see the full log here (spent 7min)

\u001b[31m    <body>And this one ever later</body>\u001b[0m
\u001b[31m    <file>test/a/b/c/Sample.java</file>\u001b[0m
\u001b[31m  </puzzle>\u001b[0m
\u001b[31m  <puzzle>\u001b[0m
\u001b[31m    <ticket>F-78-3</ticket>\u001b[0m
\u001b[31m    <estimate>120</estimate>\u001b[0m
\u001b[31m    <role>DEV</role>\u001b[0m
\u001b[31m    <id>F-78-3-c156b672</id>\u001b[0m
\u001b[31m    <lines>5-6</lines>\u001b[0m
\u001b[31m    <body>This is for a developer who will join us later</body>\u001b[0m
\u001b[31m    <file>test/a/b/c/Sample.java</file>\u001b[0m
\u001b[31m  </puzzle>\u001b[0m
\u001b[31m  <puzzle>\u001b[0m
\u001b[31m    <ticket>44</ticket>\u001b[0m
\u001b[31m    <estimate>0</estimate>\u001b[0m
\u001b[31m    <role>DEV</role>\u001b[0m
\u001b[31m    <id>44-dc333757</id>\u001b[0m
\u001b[31m    <lines>7-9</lines>\u001b[0m
\u001b[31m    <body>This puzzle has a correct format even though it doesn't start with a space on the second and the third lines</body>\u001b[0m
\u001b[31m    <file>test/a/b/c/Sample.java</file>\u001b[0m
\u001b[31m  </puzzle>\u001b[0m
\u001b[31m</puzzles>\u001b[0m
\u001b[31m (RuntimeError)\u001b[0m
\u001b[31m/home/r/repo/features/step_definitions/steps.rb:60:in `/^XML matches "([^"]+)"$/'\u001b[0m
\u001b[31mfeatures/parsing.feature:47:in `Then XML matches "/puzzles[count(puzzle)=3]"'\u001b[0m

\u001b[31mFailing Scenarios:\u001b[0m
\u001b[31mcucumber features/catches_broken_puzzles.feature:6\u001b[0m\u001b[90m # Scenario: Throwing exception on broken puzzles\u001b[0m
\u001b[31mcucumber features/parsing.feature:28\u001b[0m\u001b[90m # Scenario: Multiple puzzles in one file\u001b[0m

23 scenarios (\u001b[31m2 failed\u001b[0m, \u001b[36m1 skipped\u001b[0m, \u001b[32m20 passed\u001b[0m)
105 steps (\u001b[31m2 failed\u001b[0m, \u001b[36m14 skipped\u001b[0m, \u001b[32m89 passed\u001b[0m)
0m8.377s
/home/r/.ruby/gems/cucumber-core-3.1.0/lib/cucumber/core/test/result.rb:12: warning: calling private without arguments inside a method may not have the intended effect
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
Coverage report generated for Cucumber Features, Unit Tests to /home/r/repo/coverage. 341 / 357 LOC (95.52%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
container d42034763b7b8b48b42980fdc9f13b4aba7ed0ff9a04b03c6edfa054aaf56d95 is dead
Mon Jan 10 17:50:50 CET 2022

@mbao01
Copy link
Contributor Author

mbao01 commented Jan 12, 2022

Still trying to figure out what the issue is here. It passes locally.

Also, I created an issue to properly encode/clean up the comment/log by 0pdd. Very hard to read!

@mbao01
Copy link
Contributor Author

mbao01 commented Feb 7, 2022

@yegor256 Please review. I found and fixed the issue.

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 11, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 62e2210 into cqfn:master Feb 11, 2022
@rultor
Copy link
Collaborator

rultor commented Feb 11, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 6min)

This was referenced Feb 11, 2022
Closed
Open
@mbao01 mbao01 mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbao01 @yegor256 @rultor