#126 Start using aruba to test stderr. #129

aivinog1 · 2019-07-09T11:44:57Z

This is a fix to #126. I've tried to use Aruba to catch stderr.

0crat · 2019-07-09T11:45:03Z

@yegor256 /z please, pay attention to this pull request

0crat · 2019-07-09T11:47:35Z

Job #129 is now in scope, role is REV

codecov-io · 2019-07-09T11:48:52Z

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files           9        9           
  Lines         292      292           
=======================================
  Hits          288      288           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639dac6...7f32468. Read the comment docs.

0crat · 2019-07-09T12:44:10Z

@yegor256 /z everybody who has role REV is banned at #129; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

yegor256 · 2019-07-10T07:28:30Z

@rultor merge

rultor · 2019-07-10T07:34:58Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-07-10T07:38:05Z

@rultor merge

@aivinog1 @yegor256 Oops, I failed. You can see the full log here (spent 3min)

Excluding lib/pdd/source.rb
Excluding test/test_source.rb
Excluding test/test_source_todo.rb
Excluding test/test_pdd.rb
Excluding src/main/resources/images/**/*
45 file(s) found, 1795 excluded
/home/r/repo/test_assets/cambria.woff is a binary file (87722 bytes)
/home/r/repo/test_assets/aladdin.jpg is a binary file (115758 bytes)
/home/r/repo/test_assets/elegant-objects.png is a binary file (30969 bytes)
/home/r/repo/test_assets/favicon.ico is a binary file (3038 bytes)
/home/r/repo/test_assets/article.pdf is a binary file (84533 bytes)
Reading .simplecov...
Reading Rakefile...
Reading Gemfile...
Reading .0pdd.yml...
Reading .github/ISSUE_TEMPLATE.md...
Reading .github/PULL_REQUEST_TEMPLATE.md...
Reading cucumber.yml...
Reading .travis.yml...
Reading LICENSE.txt...
Reading test/test_sources.rb...
Reading test/test_rake_task.rb...
Reading test/test_duplicates.rb...
Reading test/test_text.rb...
Reading test/test_roles.rb...
Reading test/test_estimates.rb...
Reading test/test__helper.rb...
Reading .pdd...
Reading .rultor.yml...
Reading lib/pdd/rake_task.rb...
Puzzle 114-b69d9185 30/DEV at lib/pdd/rake_task.rb
Reading lib/pdd/sources.rb...
Puzzle 98-9de926c6 30/DEV at lib/pdd/sources.rb
Reading lib/pdd/rule/duplicates.rb...
Reading lib/pdd/rule/text.rb...
Reading lib/pdd/rule/roles.rb...
Reading lib/pdd/rule/estimates.rb...
Reading lib/pdd/puzzle.rb...
Reading lib/pdd/version.rb...
Reading lib/pdd.rb...
Reading appveyor.yml...
Reading assets/puzzles.xsd...
Reading assets/puzzles.xsl...
Reading .rubocop.yml...
Reading .gitignore...
Reading pdd.gemspec...
Reading Gemfile.lock...
Reading features/rake.feature...
Puzzle 126-b15747d8 30/DEV at features/rake.feature
Reading features/support/env.rb...
Reading features/gem_package.feature...
Reading features/step_definitions/steps.rb...
Reading bin/pdd...
Reading .gitattributes...
\u001b[31mERROR\u001b[0m: Puzzle features/rake.feature:9-10 has a very short description of just 18 words while a minimum of 20 is required
\u001b[31mERROR\u001b[0m: 1 errors, see log above
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1
container bce732587fd43f1b77cafca069168165ba7e0ff96feff3d136ffd4d25b61fb11 is dead
Wed Jul 10 09:37:57 CEST 2019

aivinog1 · 2019-07-10T07:48:48Z

@yegor256 I've fixed my puzzle message, can you try to merge again, please?

yegor256 · 2019-07-11T08:17:20Z

@rultor merge

rultor · 2019-07-11T08:29:09Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-07-11T08:32:36Z

@rultor merge

@aivinog1 @yegor256 Oops, I failed. You can see the full log here (spent 3min)

Reading pdd.gemspec...
Reading Gemfile.lock...
Reading features/rake.feature...
Puzzle 126-b07582a4 30/DEV at features/rake.feature
Reading features/support/env.rb...
Reading features/gem_package.feature...
Reading features/step_definitions/steps.rb...
Reading bin/pdd...
Reading .gitattributes...
+ LC_ALL=US-ASCII
+ bundle exec rake
/home/r/.ruby/gems/minitest-5.5.0/lib/minitest/assertions.rb:413: warning: mismatched indentations at 'ensure' with 'begin' at 404
/home/r/.ruby/gems/minitest-5.5.0/lib/minitest/assertions.rb:452: warning: mismatched indentations at 'ensure' with 'begin' at 437
Run options: --seed 38621

# Running:

\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[31mERROR\u001b[0m: Puzzle a.txt:1-1 has an estimate of 0 minutes, which is lower than 30 minutes
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0mNOT IMPLEMENTED
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

Finished in 0.975886s, 43.0378 runs/s, 93.2486 assertions/s.

42 runs, 91 assertions, 0 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/r/repo/coverage. 292 / 296 LOC (98.65%) covered.
/usr/local/rvm/rubies/ruby-2.6.0/bin/ruby -S bundle exec cucumber features --format progress
Using the default profile...
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[31mERROR\u001b[0m: there are 2 duplicate(s) of the same puzzle: Sample.java:3-3, Sample.java:4-4, while maximum 1 duplicate is allowed
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m/tmp/test20190711-10907-ya3hfr/pdd/lib/pdd/version.rb:26: warning: already initialized constant PDD::VERSION
/home/r/repo/lib/pdd/version.rb:26: warning: previous definition of VERSION was here
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[35m    The /^I run "(.*)"$/ step definition is deprecated. Please use the `backticks` version\u001b[0m
Please pass options to `#run_command_and_stop` as named parameters/hash and don't use the old style with positional parameters, NEW: e.g. `#run_command_and_stop('cmd', :exit_timeout => 5)`.. Called by /home/r/.ruby/gems/aruba-0.14.10/lib/aruba/cucumber/deprecated.rb:50:in `block in <top (required)>'
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[31mF\u001b[0m\u001b[36m-\u001b[0m\u001b[36m-\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m/tmp/test20190711-10907-zw4v7s/pdd/lib/pdd/version.rb:26: warning: already initialized constant PDD::VERSION
/home/r/repo/lib/pdd/version.rb:26: warning: previous definition of VERSION was here
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

\u001b[31m(::) failed steps (::)\u001b[0m

\u001b[31mexpected "rake aborted!\nDon't know how to build task 'bin/pdd' (see --tasks)\n/home/r/.ruby/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'\n/home/r/.ruby/bin/ruby_executable_hooks:24:in `eval'\n/home/r/.ruby/bin/ruby_executable_hooks:24:in `<main>'\n(See full trace by running task with --trace)" to string includes: "NOT IMPLEMENTED"\u001b[0m
\u001b[31mDiff:\u001b[0m
\u001b[31m@@ -1,2 +1,7 @@\u001b[0m
\u001b[31m-NOT IMPLEMENTED\u001b[0m
\u001b[31m+rake aborted!\u001b[0m
\u001b[31m+Don't know how to build task 'bin/pdd' (see --tasks)\u001b[0m
\u001b[31m+/home/r/.ruby/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'\u001b[0m
\u001b[31m+/home/r/.ruby/bin/ruby_executable_hooks:24:in `eval'\u001b[0m
\u001b[31m+/home/r/.ruby/bin/ruby_executable_hooks:24:in `<main>'\u001b[0m
\u001b[31m+(See full trace by running task with --trace)\u001b[0m
\u001b[31m (RSpec::Expectations::ExpectationNotMetError)\u001b[0m
\u001b[31mfeatures/rake.feature:13:in `And the stderr should contain:'\u001b[0m

\u001b[31mFailing Scenarios:\u001b[0m
\u001b[31mcucumber features/rake.feature:2\u001b[0m\u001b[90m # Scenario: For now we failed if run rake task\u001b[0m

25 scenarios (\u001b[31m1 failed\u001b[0m, \u001b[36m1 skipped\u001b[0m, \u001b[32m23 passed\u001b[0m)
111 steps (\u001b[31m1 failed\u001b[0m, \u001b[36m9 skipped\u001b[0m, \u001b[32m101 passed\u001b[0m)
0m6.804s
Coverage report generated for Cucumber Features, Unit Tests to /home/r/repo/coverage. 293 / 296 LOC (98.99%) covered.
SimpleCov failed with exit 1container 0b1330b0cc294e0224ac5dba9f6b3bb93aa7d96e4410afbd78c9f9d05d719fc0 is dead
Thu Jul 11 10:32:29 CEST 2019

aivinog1 · 2019-07-11T09:16:03Z

@yegor256 I've fixed my failing test. Can you merge this again, please?

0crat · 2019-07-14T13:44:49Z

@yegor256 /z everybody who has role REV is banned at #129; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

yegor256 · 2019-07-14T19:27:23Z

@rultor merge

rultor · 2019-07-14T19:28:33Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-07-14T19:31:52Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

0crat · 2019-07-14T19:49:38Z

Job gh:yegor256/pdd#129 is not assigned, can't get performer

0crat · 2019-07-14T19:49:51Z

The job #129 is now out of scope

0crat · 2019-07-14T19:50:52Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @yegor256 /z

0crat added the scope label Jul 9, 2019

Alexey Vinogradov added 3 commits July 11, 2019 15:45

cqfn#126 Start using aruba to test stderr.

524d4a1

cqfn#126 Add more words about the new puzzle.

140b212

cqfn#126 Fix a failed test

7f32468

aivinog1 force-pushed the stderr-test branch from 7f901d0 to 7f32468 Compare July 11, 2019 09:06

aivinog1 mentioned this pull request Jul 13, 2019

rake.feature:11-13: For now, there haven't a proper... #126

Closed

rultor merged commit 7f32468 into cqfn:master Jul 14, 2019

0crat removed the scope label Jul 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#126 Start using aruba to test stderr. #129

#126 Start using aruba to test stderr. #129

aivinog1 commented Jul 9, 2019 •

edited

0crat commented Jul 9, 2019

0crat commented Jul 9, 2019

codecov-io commented Jul 9, 2019 •

edited

0crat commented Jul 9, 2019

yegor256 commented Jul 10, 2019

rultor commented Jul 10, 2019

rultor commented Jul 10, 2019

aivinog1 commented Jul 10, 2019

yegor256 commented Jul 11, 2019

rultor commented Jul 11, 2019

rultor commented Jul 11, 2019

aivinog1 commented Jul 11, 2019

0crat commented Jul 14, 2019

yegor256 commented Jul 14, 2019

rultor commented Jul 14, 2019

rultor commented Jul 14, 2019

0crat commented Jul 14, 2019

0crat commented Jul 14, 2019

0crat commented Jul 14, 2019

#126 Start using aruba to test stderr. #129

#126 Start using aruba to test stderr. #129

Conversation

aivinog1 commented Jul 9, 2019 • edited

0crat commented Jul 9, 2019

0crat commented Jul 9, 2019

codecov-io commented Jul 9, 2019 • edited

Codecov Report

0crat commented Jul 9, 2019

yegor256 commented Jul 10, 2019

rultor commented Jul 10, 2019

rultor commented Jul 10, 2019

aivinog1 commented Jul 10, 2019

yegor256 commented Jul 11, 2019

rultor commented Jul 11, 2019

rultor commented Jul 11, 2019

aivinog1 commented Jul 11, 2019

0crat commented Jul 14, 2019

yegor256 commented Jul 14, 2019

rultor commented Jul 14, 2019

rultor commented Jul 14, 2019

0crat commented Jul 14, 2019

0crat commented Jul 14, 2019

0crat commented Jul 14, 2019

aivinog1 commented Jul 9, 2019 •

edited

codecov-io commented Jul 9, 2019 •

edited