Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#197] Avoiding repeated calls #198

Merged
merged 1 commit into from Mar 31, 2022
Merged

[#197] Avoiding repeated calls #198

merged 1 commit into from Mar 31, 2022

Conversation

Doldrums
Copy link
Contributor

Solving issue #197.

@Doldrums
Copy link
Contributor Author

@yegor256 please review

@Doldrums
Copy link
Contributor Author

@yegor256 It is important to clarify that the call to the #check_rules() method should occur after the call to #match_markers(). Since it is in the match_markers that the string is checked for the presence of keywords.
So it is logical to combine these checks, which will allow us to win in optimization by excluding obviously unnecessary compilations of regular expressions.

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 31, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1b4e3ef into cqfn:master Mar 31, 2022
@rultor
Copy link
Collaborator

rultor commented Mar 31, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Doldrums @yegor256 @rultor