Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEMI: recommendation api #121

Merged
merged 17 commits into from
Feb 1, 2021
Merged

SEMI: recommendation api #121

merged 17 commits into from
Feb 1, 2021

Conversation

KatGarmash
Copy link
Member

@KatGarmash KatGarmash commented Jan 27, 2021 •
edited

the entrypoint is ```recommend_for_method'''

@KatGarmash KatGarmash linked an issue Jan 27, 2021 that may be closed by this pull request
SEMI: convenient API for EMO recommendation #118
Closed
lyriccoder
lyriccoder requested changes Jan 27, 2021
View reviewed changes
veniq/baselines/semi/recommend.py Outdated Show resolved Hide resolved
@KatGarmash KatGarmash mentioned this pull request Jan 27, 2021
Closed
acheshkov
acheshkov requested changes Jan 29, 2021
View reviewed changes
veniq/baselines/semi/recommend.py
return extraction_opportunities_groups


def _convert_ExtractionOpportunity_to_EMO(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a long method ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

test/baselines/semi/test_recommend.py Outdated Show resolved Hide resolved
Ekaterina Garmash WX5328958 added 2 commits January 29, 2021 10:42
@KatGarmash
Copy link
Member Author

@acheshkov made the changes you suggested, please check

acheshkov
acheshkov approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@acheshkov acheshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KatGarmash KatGarmash merged commit a8bccba into master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acheshkov acheshkov acheshkov approved these changes

@lyriccoder lyriccoder lyriccoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEMI: convenient API for EMO recommendation
3 participants
@KatGarmash @acheshkov @lyriccoder