Apply fixes for apply #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barhodes
added
bug
Capt-Mac
reviewed
Jun 30, 2023
...rc/main/java/org/opencds/cqf/cql/evaluator/plandefinition/dstu3/PlanDefinitionProcessor.java
Outdated
Show resolved
Hide resolved
Capt-Mac
reviewed
Jun 30, 2023
...rc/main/java/org/opencds/cqf/cql/evaluator/plandefinition/dstu3/PlanDefinitionProcessor.java
Outdated
Show resolved
Hide resolved
Capt-Mac
reviewed
Jun 30, 2023
...n/src/main/java/org/opencds/cqf/cql/evaluator/plandefinition/r5/PlanDefinitionProcessor.java
Outdated
Show resolved
Hide resolved
Capt-Mac
reviewed
Jun 30, 2023
...n/src/main/java/org/opencds/cqf/cql/evaluator/plandefinition/r5/PlanDefinitionProcessor.java
Outdated
Show resolved
Hide resolved
Capt-Mac
reviewed
Jun 30, 2023
...n/src/main/java/org/opencds/cqf/cql/evaluator/plandefinition/r5/PlanDefinitionProcessor.java
Outdated
Show resolved
Hide resolved
Capt-Mac
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues found testing against the use cases found here: https://github.com/cqframework/pd-apply/tree/main/connectathon-33
The biggest issue is the de-flattening of nested PlanDefinition actions. This flattening was occurring in the previous implementation to support CDS Hooks. This new implementation will break anything currently depending on that flattening. A translation layer for turning a RequestGroup response into a CDS Card/system action will need to be developed to support those use cases.